Draft
Conversation
…ment activity sources Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/e76fd16a-3b81-420a-88f1-bc598cf74a4d Co-authored-by: maddymontaquila <12660687+maddymontaquila@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable tracing for RabbitMQ component with v7
Enable tracing for RabbitMQ Component (v7)
Mar 27, 2026
Contributor
|
@eerhardt i thought this might be an easy one but feels like slop lol. are we up to date w rabbitmq and does it have tracing now? |
eerhardt
reviewed
Mar 30, 2026
eerhardt
reviewed
Mar 30, 2026
|
|
||
| protected override string ActivitySourceName => ""; | ||
| #if RABBITMQ_V6 | ||
| protected override string ActivitySourceName => "Aspire.RabbitMQ.Client"; |
eerhardt
reviewed
Mar 30, 2026
| builder.AddRabbitMQClient("messaging", configureConnectionFactory: factory => factory.ClientProvidedName = "MyApp"); | ||
| ``` | ||
|
|
||
| ## Observability |
Member
There was a problem hiding this comment.
Do we have this section in other READMEs? I don't see it.
Member
There was a problem hiding this comment.
We track these in https://github.com/microsoft/aspire/blob/main/src/Components/Telemetry.md - which doesn't have the new ones - RabbitMQ.Client.Publisher and Subscriber
eerhardt
reviewed
Mar 30, 2026
| RunWithConnectionString(connectionStringToUse, static obj => obj.RunActivitySourceTest(key: "key")), | ||
| ConnectionString, Output); | ||
|
|
||
| private void RunActivitySourceTest(string? key) |
Member
There was a problem hiding this comment.
Why can't this call the base test method?
aspire/tests/Aspire.Components.Common.TestUtilities/ConformanceTests.cs
Lines 488 to 493 in 2916fba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RabbitMQ.Client v7 ships built-in OpenTelemetry activity sources (
RabbitMQ.Client.PublisherandRabbitMQ.Client.Subscriber). The code to register these sources viaAddSource("RabbitMQ.Client.*")was already in place for v7 but lacked conformance tests and documentation.Changes
ConformanceTests.csActivitySourceNameconditionally:"Aspire.RabbitMQ.Client"for v6,"RabbitMQ.Client.Publisher"for v7TracingEnablesTheRightActivitySource/TracingEnablesTheRightActivitySource_Keyedtests (v7 only via#if !RABBITMQ_V6), following the same pattern as Npgsql/MySqlConnectorRunActivitySourceTestinstead of base classActivitySourceTest:IConnectioncreation generates connection activities beforeTriggerActivityis called, which breaks the base classAssert.Emptycheck — the custom method clears those before asserting on publisher activitiesPopulateConfigurationto use a storedConnectionStringproperty (required to pass the connection string into theRemoteExecutorsubprocess)README.mdAspire.RabbitMQ.Client,RabbitMQ.Client.Publisher,RabbitMQ.Client.Subscriber)_AppHost.cs_→_Program.cs_Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.